Revert "use tcx.used_crates(()) more" before it reaches beta
#126068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Nice that you added tests! |
|
Only one, though I should probably add the last mcve, that seems doable as an rmake test since ui tests won’t work. The other issues can involve hundreds of crates so there are no repros unfortunately. edit: it's not yet possible to add the #125474 mcve as an rmake test. |
jieyouxu
reviewed
Jun 6, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
Jun 6, 2024
Revert "use `tcx.used_crates(())` more" before it reaches beta There are more open issues caused by rust-lang#124976 than will be fixed by rust-lang#125493 alone. The beta cut is soon, so let's revert it and buy some time to analyze and fix these issues in our own time. fixes rust-lang#125474 fixes rust-lang#125484 fixes rust-lang#125646 fixes rust-lang#125707 fixes rust-lang#126066 fixes rust-lang#125934 fixes rust-lang#126021 r? `@petrochenkov` `@bors` p=1
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 6, 2024
Revert "use `tcx.used_crates(())` more" before it reaches beta There are more open issues caused by rust-lang#124976 than will be fixed by rust-lang#125493 alone. The beta cut is soon, so let's revert it and buy some time to analyze and fix these issues in our own time. fixes rust-lang#125474 fixes rust-lang#125484 fixes rust-lang#125646 fixes rust-lang#125707 fixes rust-lang#126066 fixes rust-lang#125934 fixes rust-lang#126021 r? ``@petrochenkov`` ``@bors`` p=1
|
revert during beta week, let's go. |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (98489f2): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -2.2%, secondary -0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: missing data |
Closed
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 13, 2024
Revert "use `tcx.used_crates(())` more" before it reaches beta There are more open issues caused by rust-lang#124976 than will be fixed by rust-lang#125493 alone. The beta cut is soon, so let's revert it and buy some time to analyze and fix these issues in our own time. fixes rust-lang#125474 fixes rust-lang#125484 fixes rust-lang#125646 fixes rust-lang#125707 fixes rust-lang#126066 fixes rust-lang#125934 fixes rust-lang#126021 r? `@petrochenkov` `@bors` p=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are more open issues caused by #124976 than will be fixed by #125493 alone. The beta cut is soon, so let's revert it and buy some time to analyze and fix these issues in our own time.
fixes #125474
fixes #125484
fixes #125646
fixes #125707
fixes #126066
fixes #125934
fixes #126021
r? @petrochenkov
@bors p=1